You are right that collector cars like this go up in value, but that is usually only true if it is not being driven much. Actually go out and drive a lot in it, and that $250k value will lower.
I can see where you could get enjoyment out of the car if you are a massive car enthusiast, but I still think that enjoyment will diminish over the years. There will be another car that you want in the future, because you like cars. Just like how we get really excited about games, but after a while we are more excited about the next one. Yes, car will last longer than a single game, but overtime you will want something else.
Under the following scenario I would take the car:
- the stipulation is only for this current generation of console games, and not ones in the future.
- I am allowed to sell the car, so once I am done having my fun in it, I can get some sort of monetary value out of it. If I cannot sell the car, then the worth of the car no longer matters, we are just comparing entertainment value, and I find a variety of games more entertaining than a single car.
- I can use the loophole to buy GamePass and/or PSN to get games

(however, I could look over this one, if I can sell the car at the end of this console generation and get that money!)